search

refactoring-ai / predicting-refactoring-ml

Refactoring recommendation via ML
MIT License
28 stars 8 forks source link

Refactor App.java #122

Closed jan-gerling closed 4 years ago

jan-gerling commented 4 years ago

The central class of our data-collection tool (App.java) is literally one huge method, containing all the log. I suggest to refactor it:

  1. extract methods
  2. refactor attributes
  3. move methods to utils, if applicable
mauricioaniche commented 4 years ago

I agree. But let's first stabilise this version, and make sure there are no bugs. Once we are sure, refactor it will be easier.

Maurício Aniche Delft University of Technology http://www.mauricioaniche.com

On Fri, Mar 13, 2020 at 12:40 PM Jan Gerling notifications@github.com wrote:

The central class of our data-collection tool (App.java https://github.com/refactoring-ai/predicting-refactoring-ml/blob/21319e0aaea395b9665d62205fd758cf8fbf59a0/data-collection/src/main/java/refactoringml/App.java#L32) is literally one huge method, containing all the log. I suggest to refactor it:

  1. extract methods
  2. refactor attributes
  3. move methods to utils, if applicable

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/refactoring-ai/predicting-refactoring-ml/issues/122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYTTFMAUMMJA5WV6VT5U3RHILSHANCNFSM4LHAVVOA .

mauricioaniche commented 4 years ago

Indeed, the name of the parameter there is datasetName and not projectName. Note how the project name is actually extracted from the GitUrl inside initProject. Just fixed it.