search

refactoring-ai / predicting-refactoring-ml

Refactoring recommendation via ML
MIT License
28 stars 8 forks source link

Parallel Logging causing faulty log files #138

Closed jan-gerling closed 4 years ago

jan-gerling commented 4 years ago

I noticed during the second stress test (#95), that the logs are overwritten, especially the debug logs.

mauricioaniche commented 4 years ago

That's definitely possible. Are we storing the logs of all the docker images in a single file?

jan-gerling commented 4 years ago

That's definitely possible. Are we storing the logs of all the docker images in a single file?

No, we use a rolling file appender, but it is not behaving as it is supposed to. https://github.com/refactoring-ai/predicting-refactoring-ml/blob/9491f9bb7718f5b2852b372e2ad346ca94c6f3f6/data-collection/src/main/resources/log4j2.xml#L13-L23

mauricioaniche commented 4 years ago

The rolling appender is just about the size of the file. All the docker images write at the same file at the same time, as far as I can see in the config. We should create different log files for the different machines. Maybe we add an environment variable that represents the image in the file name ?

On Mon, 16 Mar 2020 at 08:40, Jan Gerling notifications@github.com wrote:

That's definitely possible. Are we storing the logs of all the docker images in a single file?

No, we use a rolling file appender, but it is not behaving as it is supposed to.

https://github.com/refactoring-ai/predicting-refactoring-ml/blob/9491f9bb7718f5b2852b372e2ad346ca94c6f3f6/data-collection/src/main/resources/log4j2.xml#L13-L23

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/refactoring-ai/predicting-refactoring-ml/issues/138#issuecomment-599388181, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYTTHBIDFYTKQORDJULTLRHXJWVANCNFSM4LLCHUKA .

--

Maurício Aniche Delft University of Technology http://www.mauricioaniche.com