refactoring-ai / predicting-refactoring-ml

Refactoring recommendation via ML
MIT License
28 stars 8 forks source link

Unhandeld Javaparser Exceptions #94

Closed jan-gerling closed 4 years ago

jan-gerling commented 4 years ago

In rare cases, the call to SourceCodeUtils.removeComments can throw a ParseException: image

How to deal with these classes?

All found examples (31):

mauricioaniche commented 4 years ago

Maybe we can fall back to a String manipulation method if JavaParser fails? CK has an utility method that counts lines looking at the stringified code only.

On Fri, 6 Mar 2020 at 19:44, Jan Gerling notifications@github.com wrote:

In rare cases, the call to SourceCodeUtils.removeComments https://github.com/refactoring-ai/predicting-refactoring-ml/blob/9210fa3e1b52fa156e7d80730c65619f8292abfe/data-collection/src/main/java/refactoringml/util/SourceCodeUtils.java#L8 can throw a ParseException: [image: image] https://user-images.githubusercontent.com/29139613/76112522-ab55dc80-5fe2-11ea-9de1-f22d23aff930.png

How to deal with these classes?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/refactoring-ai/predicting-refactoring-ml/issues/94?email_source=notifications&email_token=AAAYTTD7VEVYFUYDYQCFAQLRGE77JA5CNFSM4LDFYCH2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ITF7KEA, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAYTTCG5WUFIRNAFOJ25DDRGE77JANCNFSM4LDFYCHQ .

--

Maurício Aniche Delft University of Technology http://www.mauricioaniche.com

mauricioaniche commented 4 years ago

As discussed: