search

refactory-id / bootstrap-markdown

Bootstrap plugin for markdown editing
Apache License 2.0
1.99k stars 371 forks source link

More accurate toolbar button construction #102

Closed duhast closed 10 years ago

duhast commented 10 years ago

Hi! I've noted there was some unwanted CSS classes on the Preview button, so I've rewrote toolbar buttons creation routine in a jQuery-way.

Before: screenshot 2014-09-10 02 53 32

After: screenshot 2014-09-10 03 44 24

P.S. I use custom button styles, that's why my buttons doesn't look like standard BS3 flat buttons.

acrobat commented 10 years ago

:+1:

toopay commented 10 years ago

@duhast thanks for spotting that culprit. Can you standarize the variable naming convention with the rest of the block?

duhast commented 10 years ago

Sure @toopay. Just to confirm - you mean to remove $ ?

toopay commented 10 years ago

Yes, and use more verbose camelCased word if necessary (buttonIcon - or buttonIconContainer - instead icon)

duhast commented 10 years ago

Done

toopay commented 10 years ago

Thanks @duhast

duhast commented 10 years ago

You welcome :smiley: !