search

refactory-id / bootstrap-markdown

Bootstrap plugin for markdown editing
Apache License 2.0
1.99k stars 370 forks source link

fix(): indent code and fix missing semicolon #243

Closed Magicalex closed 8 years ago

Magicalex commented 8 years ago
Magicalex commented 8 years ago

@toopay any news?

toopay commented 8 years ago

@Magicalex I saw a bunch of spacing/indentations diff in the PR, make it harder to review the actual changes. Can you leave them as they were?

Magicalex commented 8 years ago

Yes I can leave them but I just follow rules in your .editorconfig

acrobat commented 8 years ago

You can check the diff with ?w=0 at the end of the url to remove those space changes from the diff.

toopay commented 8 years ago

Thanks for the tip @acrobat, didn't know that query string option exists.

@Magicalex Can you please check all translations files as well? I see that you're only change some of them.

Magicalex commented 8 years ago

I check all translation files asap

Magicalex commented 8 years ago

Done! I make a new PR because I changed of branch new PR here : https://github.com/toopay/bootstrap-markdown/pull/249