search

refactory-id / bootstrap-markdown

Bootstrap plugin for markdown editing
Apache License 2.0
1.99k stars 370 forks source link

Add minify.sh to minifying javascript #267

Closed bekicot closed 7 years ago

bekicot commented 7 years ago

The reason i propose to use bash script instead of grunt is to eliminate complexity in the repo. We only want to minify css and javascript no other things

@toopay which one is converted to css/bootstrap-markdown.min.css , the less file or the sass file ?

Magicalex commented 7 years ago

Hi, thanks for your contribution. But, I think a task runner like gulp seems to be more appropriate for minifying css files and more.

bekicot commented 7 years ago

@magicalex As specified in the message. The main reason is to eliminate complexity.

Gulp is great, but have a lot of dependencies, hence, the only reason i made it is to minify the js. And yuicompressor is doing a great job for it.

Can you ellaborate what does 'more' means ? And how is 'more' being used in this project ?

If it reasonable, i will gladly help, and made another commit which is using gulp.

*I like gulp and have used it on some project.

toopay commented 7 years ago

Closed for now.