search

refactory-id / bootstrap-markdown

Bootstrap plugin for markdown editing
Apache License 2.0
1.99k stars 371 forks source link

Add the possibility to use the Bootstrap Modal instead of the JS Prompt #48

Closed emagnier closed 10 years ago

emagnier commented 10 years ago

It keeps exactly the same behaviour, but uses the Bootstrap Modal instead on the classic JS prompt. By default this option is disabled.

E.g.:

$("#target-editor").markdown({
  useModal: true
})
emagnier commented 10 years ago

Related to https://github.com/toopay/bootstrap-markdown/issues/13.

toopay commented 10 years ago

I'm not sure about this. So far, we only depend on bootstrap style sheet, this will make us to depend on entire bootstrap plugin which undesired since there is a chance that people already extend bootstrap modal with non-standard library.

emagnier commented 10 years ago

In fact it only need the bootstrap js plugin if useModal is set to true.

But I understand your point, I had the same feeling when I added all the markup and mechanics in the core plugin. So I moved my code on the custom side of my project.

However this issue https://github.com/toopay/bootstrap-markdown/issues/13 is still open (I made this PR because of that). Should we closes it and explain why? And/or move my implementation from this PR to an example of custom feature?