search

referencedev / staking-farm

Staking contract with farming capability
19 stars 16 forks source link

Issues with HowTo.md doc #4

Open esaminu opened 2 years ago

esaminu commented 2 years ago

Hello all, I found a couple of issues with the HowTo.md doc on this repo:

  1. The nearkey install command appears to be broken. The url needs to be github.com/aurora-is-near/near-api-go/cmd/nearkey in my testing. The command should be 
    go install github.com/aurora-is-near/near-api-go/cmd/nearkey@latest
  2. The create_staking_pool function call in step 7 of the Deploy Stake&Farm section appears to be missing the owner_id property in the arguments like in the source code of the contract.
  3. There's an extra single quote in step 9 of the Deploy Stake&Farm section. The command should be: 
    near view ${WHITELIST} is_whitelisted '{"staking_pool_account_id":"'${STAKINGCONTRACT}'"}'
  4. The claim function call in the Cashing out farmed tokens section appears to mismatch the arguments in the source code of the function.
JonathanLogan commented 2 years ago

Good finds. Please create a pull request and contribute :)