search

refgenie / refgenconf

A Python object for standardized reference genome assets.
http://refgenie.databio.org
BSD 2-Clause "Simplified" License
3 stars 6 forks source link

minimum version #26

Closed nsheff closed 5 years ago

nsheff commented 5 years ago

is the minimum version really 3.5? why?

https://github.com/databio/refgenconf/blob/eb45a8549024214f4f083e505f8e8599846e59b4/setup.py#L4

vreuter commented 5 years ago

Because during initial development discussion with you and @michalstolarczyk it was decided to only support Python 3 for the refgenie suite of packages (this, server, and conf). 3.4 is considered "end of life," so minimum bound of 3.5 seems reasonable; this formalizes it so we don't have users installing on platforms that we have no desire to support.

vreuter commented 5 years ago

https://www.python.org/downloads/release/python-340/

nsheff commented 5 years ago

I was just curious if it actually didn't work on python 2.

The thing is, this will make pepatac for example also require python 3 since it will import refgenconf (but we still don't even have a version released that works in python 3), making this a little complicated...