search

reficio / p2-maven-plugin

Maven3 plugin that automates the third-party dependency management for Eclipse RCP
http://reficio.org
230 stars 100 forks source link

Allow exclude at root level #267

Open castortech opened 3 years ago

castortech commented 3 years ago

We create a number of p2 sites for different jars and use transitive resolution to resolve all dependencies. But we often end up with dependencies that are already part of another site. For example we have an apache commons p2 site with a number of apache projects. Then we have a keycloak one that pulls in a lot of apache jars that we want to exclude since they are already part of the apache p2 site.

Right now we are left with add exclude for each artifact that we find is pulling those dependencies which is very time consuming and error prone. It would be much simpler to add a top level excludes that specifies all global excludes and that get added to specific artifact exclude if any.

I looked at the code and think it would be quite easy to implement, but would first like to get some feedback before moving forward and creating a pull request for this.

Thanks Alain

sparsick commented 3 years ago

Thanks for request. I think your issue relates to this feature request #132 . Let me think about a config structure that can handle both requirements. I will be part of the Hack.Commit.Push Event. Maybe you have time to discuss a well-defined structure.

castortech commented 3 years ago

Let me try to provide a bit more concrete idea about this, in light of the other mentioned issues.