reficio / soap-ws

Java library, based on Spring-WS, that enables handling SOAP on a purely XML level
298 stars 146 forks source link

Source in repo != source used in repo jar #15

Closed ghost closed 11 years ago

ghost commented 11 years ago

Hi!

I just looked in the soap-client.jar that maven pulls. The SoapClient class isn't the one in the repo. In git, the DefaultHTTPClient is initialized when the SoapClient is built. In the jar file, the DefaultHTTPClient is redone whenever a POST is done.

That means that it's impossible to add an interceptor or manipulate the HTTP client before the POST goes out. It also makes HTTP sessions impossible.

Is the JAR source and older version that hasn't been updated to the git version, or a new source that hasn't had its source checked in yet?

tombujok commented 11 years ago

Hi, it's possible. The deploy build has failed: https://reficio.ci.cloudbees.com/job/soap-ws-deploy/ If you have time, could you have a look why the test is failing?

On Monday, August 5, 2013 at 8:02 PM, mannyveloso wrote:

Hi! I just looked in the soap-client.jar that maven pulls. The SoapClient class isn't the one in the repo. In git, the DefaultHTTPClient is initialized when the SoapClient is built. In the jar file, the DefaultHTTPClient is redone whenever a POST is done. That means that it's impossible to add an interceptor or manipulate the HTTP client before the POST goes out. It also makes HTTP sessions impossible. Is the JAR source and older version that hasn't been updated to the git version, or a new source that hasn't had its source checked in yet?

— Reply to this email directly or view it on GitHub (https://github.com/reficio/soap-ws/issues/15).

ghost commented 11 years ago

Looks like SimpleClientTest is trying to connect to test.ch, which doesn't exist anymore.

tombujok commented 11 years ago

pull request with fix appreciated ;)

Tom Bujok Reficio™ - Reestablish your software! http://www.reficio.org

On Monday, August 5, 2013 at 11:19 PM, mannyveloso wrote:

Looks like SimpleClientTest is trying to connect to test.ch (http://test.ch), which doesn't exist anymore.

— Reply to this email directly or view it on GitHub (https://github.com/reficio/soap-ws/issues/15#issuecomment-22141847).

tombujok commented 11 years ago

Should be fine. The artifacts have been just deployed to the repo.