search

reficio / soap-ws

Java library, based on Spring-WS, that enables handling SOAP on a purely XML level
297 stars 145 forks source link

Could client.core.SoapClient be non-final #26

Open KLBonn opened 10 years ago

KLBonn commented 10 years ago

Hi Tom,

could you remove the "final" from org.reficio.ws.client.core.SoapClient class?

Otherwise mocking the SoapClient in my unit tests becomes unnecessary difficult. While SoapClient is final, I can neither subclass nor use Mockito.

PowerMock would be a workaround, but I strive not to require it.

Best regards, Klaus

tombujok commented 10 years ago

Yep, that's a nice idea