search

refile / refile-s3

Amazon S3 Backend for Refile
MIT License
36 stars 88 forks source link

Raise exception for invalid s3 credentials #24

Closed sobrinho closed 7 years ago

sobrinho commented 8 years ago

See refile/refile#454

sobrinho commented 8 years ago

@jnicklas see if that's the way to go.

Basically we need better error messages due to typos instead of strange exceptions.

Does makes sense?

klausbadelt commented 8 years ago

AWS credentials as options should be actually considered optional (see other pull requests like #29 #18. Recommended on EC2 is actually instance profiles. See also AWS SDK configuration.

sobrinho commented 8 years ago

So, maybe in that case we could create a special value like Refile::S3::NO_VALUE, I don't know.

What you suggest?

We must have better exception messages.

filmhubhq commented 8 years ago

Doesn't AWS SDK already raise exceptions for missing configuration?

sobrinho commented 8 years ago

Not sure but on refile/refile#454 you will see that the error appears on refile itself, not on SDK.

sobrinho commented 7 years ago

Closing, if we found a better way to do that, a new pull request will be done.