search

refindlyllc / rets

A thin RETS client
MIT License
69 stars 26 forks source link

Rapattoni Servers on non-standard ports #190

Closed bazeli closed 6 years ago

bazeli commented 6 years ago

Hey there-

Much thanks for this helpful timesaver of a lib. I ran into an issue with a Rapattoni RETS server running on a non-standard port (ie not 80 or 443). After a bit of debugging, I made a small fix to support these cases. Default behavior doesn't change for anyone - I decided to make it opt-in based on research done with other RETS servers.

Let me know if you would like me to create a PR. Cheers!

https://github.com/bazeli/rets/commit/3498de3e242b31faf39403061da1aea28b5b9a04

mcrowson commented 6 years ago

Is there a reason why you wouldn't use the same port from the login url? I'm wondering if the copy_port parameter is necessary, or if one would always have the same port on the capabilities as the login url

bazeli commented 6 years ago

Agreed - that would be the more logical choice, but given the potential impact of the change I thought it best to make it optional. Last thing anyone wants is broken code. Up to you though.

mcrowson commented 6 years ago

The actions listed on the login page only ever show the URI. So I don't think the port would ever change from the login to other actions on the server. I don't think it would be breaking, and if it turns out to be we can address it.

mcrowson commented 6 years ago

You should see this in 0.4.5