feat: [WIP] refactor setCurrent to setPage

alicanerdurmaz commented 2 days ago

🚨 Work in progress...

PR Checklist

Please check if your PR fulfills the following requirements:

[ ] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

[ ] Related issue(s) linked
[ ] Tests for the changes have been added
[ ] Docs have been added / updated
[ ] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

What is the new behavior?

fixes #6087

Notes for reviewers

changeset-bot[bot] commented 2 days ago

⚠️ No Changeset found

Latest commit: 46d1491482639af77055f531c8718b45c372da8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cypress[bot] commented 2 days ago

30 failed tests on run #11253 ↗︎

30

351

37

0

Details:

Merge 46d1491482639af77055f531c8718b45c372da8e into 4265ae2509f79af9dbca8d52daf5...
Project: refine	Commit: `10f77cc916 ℹ️`
Status: Failed	Duration: 33:57 💡
Started: Jun 28, 2024 2:17 PM	Ended: Jun 28, 2024 2:51 PM

cypress/e2e/all.cy.ts • 1 failed test • inferencer-material-ui

View Output

Test		Artifacts
inferencer-material-ui > should work with pagination		`Test Replay` `Screenshots`

cypress/e2e/all.cy.ts • 3 failed tests • table-chakra-ui-basic

View Output

Test		Artifacts
table-chakra-ui-basic > should work with sorter		`Test Replay` `Screenshots`
table-chakra-ui-basic > should work with pagination		`Test Replay` `Screenshots`
table-chakra-ui-basic > should set current `1` when filter changed		`Test Replay` `Screenshots`

cypress/e2e/all.cy.ts • 4 failed tests • data-provider-strapi-v4

View Output

Test		Artifacts
data-provider-strapi-v4 > useList > should list with pagination		`Test Replay` `Screenshots`
data-provider-strapi-v4 > useList > should sort		`Test Replay` `Screenshots`
data-provider-strapi-v4 > useList > should filter		`Test Replay` `Screenshots`
data-provider-strapi-v4 > change locale > should change locale		`Test Replay` `Screenshots`

cypress/e2e/all.cy.ts • 4 failed tests • data-provider-supabase

View Output

Test		Artifacts
data-provider-supabase > useList > should list with pagination		`Test Replay` `Screenshots`
data-provider-supabase > useList > should sort		`Test Replay` `Screenshots`
data-provider-supabase > useList > should filter		`Test Replay` `Screenshots`
data-provider-supabase > useShow > should show		`Test Replay` `Screenshots`

cypress/e2e/all.cy.ts • 1 failed test • table-antd-table-filter

View Output

Test		Artifacts
table-antd-table-filter > the table should be filterable by form		`Test Replay` `Screenshots`

The first 5 failed specs are shown, see all 17 specs in Cypress Cloud.

Review all test suite changes for PR #6088 ↗︎

alicanerdurmaz commented 1 hour ago

After discussing this with the core team, we decided to implement it with Refine@5 because the syncWithLocation feature will cause a breaking change.

refinedev / refine