refactor(core): allow passing optional check params to Authenticated …

refinedev / refine

A React Framework for building internal tools, admin panels, dashboards & B2B apps with unmatched flexibility.

https://refine.dev

MIT License

28.6k stars 2.24k forks source link

refactor(core): allow passing optional check params to Authenticated … #6483

Open reedwane opened 1 week ago

reedwane commented 1 week ago

…component

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://refine.dev/docs/guides-concepts/contributing/#commit-convention

Bugs / Features

[x] Related issue(s) linked
[x] Tests for the changes have been added
[x] Docs have been added / updated
[x] Changesets have been added https://refine.dev/docs/guides-concepts/contributing/#creating-a-changeset

What is the current behavior?

The Authenticated component doesn't take extra params for the useIsAuthenticated hook to check the auth status

What is the new behavior?

The component now has params in the props which is then passed to the authenticated hook call, which already allows for params: any fixes (#6309)

Notes for reviewers

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: f8a4b615ab84c4ed1ecc2ea5b2c3044a1d56b915

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------- | ----- | | @refinedev/core | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

BatuhanW commented 1 week ago

Oh, a minor thing I forgot, we could also update Authenticated component documentation and mention that params can be passed to AuthProvider's check method.

reedwane commented 1 week ago

Oh. Okay @BatuhanW. sadly I have to run now...

I'm not sure why the linting is throwing an error... I installed the biome extension, but can't get it to format the file for some reason.... is this something someone else can easily help with?

reedwane commented 3 days ago

Thanks @BatuhanW. Apologies I couldn't continue since too. Have my hands quite tied presently

BatuhanW commented 2 days ago

@reedwane no worries, we'll release it around December 5th. If we can't hear back from you until then, we can update documentation.