refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
355 stars 176 forks source link

Payload Max Size Crash/Disconnect #1790

Closed artdude543 closed 2 years ago

artdude543 commented 6 years ago

Issue description:

A maker of SevTech: Ages here! Got an issue posted on our tracker about the usage of BWM Recipes on RS Pattern. Full details about the issue and how to reproduce it can be found on our ticket: https://github.com/DarkPacks/SevTech-Ages/issues/2498 (Saves on copy/paste)

Version (make sure you are on the latest version before reporting):

Does this issue occur on a server? [yes/no] yes

If a (crash)log is relevant for this issue, link it here:

https://gist.github.com/nitrous24/01f1ff00a7c3d05df2aeab46744f24e3

ThinkInvis commented 6 years ago

Confirmed for a heavily modified version of the DW20 1.12 pack, with all mods up to date as of this post (exc. Thaumcraft, due to a known severe crash bug). This is not a bug with BWM interaction specifically. Only started happening recently; it seems to trigger when using JEI to fill any recipe, at random, into the pattern grid, although I haven't tested this extensively. So far, it's happened with Actually Additions (Greenhouse Glass specifically) and Mystical Agriculture recipes. Might have something to do with trying to handle oredict for saplings, with mods like Forestry and Integrated Dynamics adding a ton of saplings?

wraithlet commented 6 years ago

Seeing same issue shift-clicking Greenhouse Glass into the crafting grid in All The Mods v5.9.5, also RS 1.5.33 and forge 1.12.2-14.23.3.2678 version. Is there any further data that can be provided to help isolate the cause?

instinxx commented 5 years ago

Have same issue that results in "Payload may not be larger than 32767 bytes". The player shift clicked the + sign in JEI to build chests in the crafting grid. Forge Mod Loader version 14.23.4.2760

CrashLog here: https://pastebin.com/f8pSZ2p7

Modlist Here: https://pastebin.com/gGTwhB2i

valveo commented 5 years ago

https://github.com/ForestryMC/ForestryMC/issues/561 This is same issue.

raoulvdberge commented 5 years ago

It's not.

valveo commented 5 years ago

Sorry, corrected link. Its related forestry bug. There are so many saplings, wood types that causing issues.

Yamza commented 5 years ago

Seems like this may be related: https://github.com/AllTheMods/ATM3-Remix/issues/82 Has been an ongoing issue.

Mitsuma commented 5 years ago

Any progress on this one? Today playing ATM3 I encountered a similar issue with the same payload error message.

I just tried to use the + from a regular chest into the pattern computer and then it disconnects. Updated Refined Storage to 1.6.12, still getting the same issue, SP or Server.

SuperSandro2000 commented 5 years ago

This issue is almost a year old by now. Does this need to be fixed on JEI side or RS or both?

turret001 commented 4 years ago

I don't know if it's RS or JEI but it still exists and it's quite annoying

ghost commented 4 years ago

Idk what the weight of this situation holds but I believe this issue is quite problematic and should take high priority. If there are no plans to sort this bug out anytime soon I believe we should know about it so that players can plan around it. I understand being a dev and having to balance a lot of problems at once is difficult but a good way to start is by giving a solid answer. I'm not trying to insult you or anyone personally or indirectly, I just believe a strong message is how one gets things done.

raoulvdberge commented 4 years ago

All what could be said about this issue has been said. This will be dealt with when I have time

raoulvdberge commented 4 years ago

Comments above deleted since they were unrelated to this issue.

raoulvdberge commented 4 years ago

Also #2378

raoulvdberge commented 2 years ago

@Darkere Is this fixed now thanks to the packet splitting?

Darkere commented 2 years ago

Yep.