refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
359 stars 177 forks source link

Item quantity quirk (1.6) #1885

Closed brisingraerowing closed 6 years ago

brisingraerowing commented 6 years ago

Issue description:

Grids show a minimum of 96 items, even if only one of any item is in the system.

What happens:

Grid shows more items than it should.

What you expected to happen:

Grid shows actual amount of items.

Steps to reproduce:

  1. Put items in the system. 2....
  2. Weird numbering. ...

Version (make sure you are on the latest version before reporting):

Does this issue occur on a server? [yes/no] Untested.

If a (crash)log is relevant for this issue, link it here:

2018-07-20_22 20 22

brisingraerowing commented 6 years ago

It appears that RS is duplicating the item data over all disks in the system. I am using Reborn Storage disks, so this may be on their end. The actual number of items in the system is correct (e.g. if a single wheat is put it, you can only pull one out).

raoulvdberge commented 6 years ago

Are you sure these items are on a disk? Aren't they in an external storage?

Can you reproduce this with an empty RS network? (1 storage disk, a controller, a grid)

brisingraerowing commented 6 years ago

The ones in external storage (storage drawers) show fine. I disconnected the storage drawers and it still did this. It seems to be related to the number of disks in the system (I had 96 disks). I'll do some testing.

brisingraerowing commented 6 years ago

It happens as soon as I connect an external storage, even if there's nothing in it.

raoulvdberge commented 6 years ago

To what are you connecting an External Storage?

raoulvdberge commented 6 years ago

Also, give me exact reproduction steps (starting off an empty system). What do I have to do, place, etc.

brisingraerowing commented 6 years ago

Any kind of inventory can be connected.

Simply set up an RS system with some disks (> 1) and put a single item in it. Then place some kind of inventory (e.g. a chest) and attach it to the system with an External Storage. The item in the system should now show the quantity as the number of disks in the system.

raoulvdberge commented 6 years ago

I can't reproduce.

With 4 disks:

x

x

raoulvdberge commented 6 years ago

Are you sure your reproduction steps are correct? Did you try to follow your own steps?

brisingraerowing commented 6 years ago

Let me do some more testing.

brisingraerowing commented 6 years ago

It looks like Reborn Storage is breaking something. I'll poke them.

raoulvdberge commented 6 years ago

What makes you think this is a Reborn Storage issue?

brisingraerowing commented 6 years ago

It only happens when that's installed. With just RS it doesn't happen.

raoulvdberge commented 6 years ago

@BrisingrAerowing I just tried the exact same setup with Reborn Storage, and I can't reproduce it?

Can you, please, be more specific? This is getting frustrating.

brisingraerowing commented 6 years ago

Weird... I'll mess with it some more.

brisingraerowing commented 6 years ago

I was able to replicate this with just RS. Here's an image of my testing setup: 2018-07-25_18 04 21

The external storage needs to be added last. There are 8 64K disks in the drive.

brisingraerowing commented 6 years ago

Here's a couple more screenshots: 2018-07-25_18 05 59 2018-07-25_18 06 02

brisingraerowing commented 6 years ago

The item that gets 'duplicated' needs to be in the system before the external storage is added, BTW. Anything added after doesn't duplicate unless another ES is added.

raoulvdberge commented 6 years ago

Weird:

x

x

x

x

My flow:

brisingraerowing commented 6 years ago

Weird it is. Something's messed up in my instance. I'll try rebuilding it and see what happens.

brisingraerowing commented 6 years ago

Still happens even after a complete recreation of that instance. Something is messed up. Might be an issue with MultiMC itself. I'll try rebuilding my entire setup.

brisingraerowing commented 6 years ago

Even a complete nuke and rebuild of my setup didn't fix it. I'm at a loss as to what could be broken.

brisingraerowing commented 6 years ago

Also, what Forge version are you using? Mine is 2739.

raoulvdberge commented 6 years ago

Can you reproduce this with only RS installed? No other mods.

brisingraerowing commented 6 years ago

Yup. That's the image above. Only RS is installed.

CrossVas commented 6 years ago

I was able to reproduce this too You must update any block from your RS system (e.g. Disk Drive or External Storage) It seems to be a block-update visual bug

Minecraft Setup: Minecraft: 1.12.2 Forge: 1.12.2-14.23.4.2739 Refined Storage: 1.6.2-256

Update

Also tried with 1.6.3-258

https://imgur.com/a/8BqAYGo

brisingraerowing commented 6 years ago

Well, at least someone else has figured something out. This was beginning to run me up the wall. I even did a refresh of my Win10 install to see if that would work (I needed to do one anyways as I had accumulated a ton of crap since the last time I did a refresh. My system runs about 90% faster now).

brisingraerowing commented 6 years ago

I just noticed something. When this issue occurs, ALL of the disks get the same UUID. I'm guessing that's the core of this issue.

raoulvdberge commented 6 years ago

I still can't reproduce the issue. I'm suspecting (aka i'm almost sure) that you guys aren't running a RS vanilla instance to test this.

x

raoulvdberge commented 6 years ago

@CrossVas

See my post above.

Are you running any other mods in the testing instance?

How did you obtain those disks? Did you create unique ones or duplicate them with middle click (so they end up having the same ID)

brisingraerowing commented 6 years ago

My instance contained Forge and RS. That's it.

brisingraerowing commented 6 years ago

I just noticed that disks get their IDs when crafted / put into the inventory. I was middle click dragging them in the drives to fill them, as shift middle clicking a drive does not include the disks in it. That's the cause of this issue here.