search

refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
359 stars 177 forks source link

1.19.2 - Refined Storage Not Caching Recipes Causing Mass Lag In Larger Machines (Forge Project Dev Report) #3496

Open P3rf3ctXZer0 opened 1 year ago

P3rf3ctXZer0 commented 1 year ago

Describe the bug

8nduoh0 1

Log: https://gist.github.com/P3rf3ctXZer0/74e7cf0c51344f3f4a674512874aa139 Debug Log: https://gist.github.com/P3rf3ctXZer0/7eac7cb6259b8692b25b4a5366277c9a

bRLwE76 1

Sparkc: https://spark.lucko.me/xUVP4IhgqM Observable: https://o.tas.sh/#wmBp

How can we reproduce this bug or crash?

Yes make a machine with over 2 million items and 160 recipes

uCkzqmS 1

am6ipOJ 1

What Minecraft version is this happening on?

Minecraft 1.19.2

What Forge version is this happening on?

43.2.8

What Refined Storage version is this happening on?

refinedstorage-1.11.6.jar

Relevant log output

Log: https://gist.github.com/P3rf3ctXZer0/74e7cf0c51344f3f4a674512874aa139
Debug Log: https://gist.github.com/P3rf3ctXZer0/7eac7cb6259b8692b25b4a5366277c9a

Sparkc: https://spark.lucko.me/xUVP4IhgqM
Observable: https://o.tas.sh/#wmBp
Darkere commented 1 year ago

You may have a bunch of encoded patterns in your grid or inventory?

raoulvdberge commented 11 months ago

Are there any particular mods that cause this issue?

raoulvdberge commented 11 months ago

RS caches the recipes so I'm not sure in which situation the cache is bypassed.

FLSoz commented 11 months ago

I can confirm this happens. Did not bother with running spark logs since I found the problematic interaction, and removed RS from my modpack. Had at most maybe 50k items in the network, and 30 crafting recipes, and got immediate lag spikes when viewing through a crafting terminal. The resolution I found was from switching from REI + REI Plugin compatibility to full JEI.