refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
362 stars 177 forks source link

Add direction null check #3647

Closed Edivad99 closed 8 months ago

Edivad99 commented 8 months ago

Fixed an error that occurred when targeting the crafter with Jade installed

Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.core.Direction.equals(Object)" because "direction" is null
    at com.refinedmods.refinedstorage.blockentity.CrafterBlockEntity.getPatterns(CrafterBlockEntity.java:48) ~[refinedstorage-1.13.0-beta.3.jar%23189!/:?] {re:classloading}
    at net.neoforged.neoforge.capabilities.RegisterCapabilitiesEvent.lambda$registerBlockEntity$1(RegisterCapabilitiesEvent.java:64) ~[neoforge-20.4.192.jar%23184%23187!/:?] {re:classloading}
    at net.neoforged.neoforge.capabilities.BlockCapability.getCapability(BlockCapability.java:158) ~[neoforge-20.4.192.jar%23184%23187!/:?] {re:classloading}
    at net.neoforged.neoforge.common.extensions.ILevelExtension.getCapability(ILevelExtension.java:74) ~[neoforge-20.4.192.jar%23184%23187!/:?] {re:classloading}
    at snownee.jade.util.CommonProxy.findItemHandler(CommonProxy.java:220) ~[jade-324717-5109393.jar%23190!/:13.3.1] {re:classloading}
    at snownee.jade.util.CommonProxy.createItemCollector(CommonProxy.java:170) ~[jade-324717-5109393.jar%23190!/:13.3.1] {re:classloading}
    at snownee.jade.addon.universal.ItemStorageProvider.lambda$getGroups$4(ItemStorageProvider.java:244) ~[jade-324717-5109393.jar%23190!/:13.3.1] {re:classloading}
raoulvdberge commented 8 months ago

Hello, can you fix the merge conflict by rebasing on develop? Thank you.

Edivad99 commented 8 months ago

@raoulvdberge done 👍🏻

raoulvdberge commented 8 months ago

Thank you