refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
355 stars 176 forks source link

Disks in drives bugged after server restart #3714

Open Einhornyordle opened 1 month ago

Einhornyordle commented 1 month ago

Describe the bug

After restarting our "All the Mods 9 - To the Sky - atm9sky" server, all disk drives appear to be empty even tho they still have disks inside of them. The disks are still there but their capacity shows 0/0. Trying to add items to them via one of the grids is not possible. Trying to dismantle them via Sneak + Right Click is also not possible.

Some players had empty storage blocks inside of their bases and could confirm that they still worked without issues, but since they were empty from the beginning its unclear if that's the reason why they still work or not.

The logs showed two interesting error messages after the shutdown command went through, I put it in the "Relevant log output" section. I can confirm that the refined storage files in the world/data/ folder have been deleted/reset due to how small the content now is. Luckily we got backups so after stopping the server again, copying these two files over from one of the backups and starting it again everything was back to normal (besides the items that got lost between the creation of the backup and the corruption/deletion of the files of course).

One other note: Since this happened before on the regular ATM9 server we decided to remove the crafting recipes of the Storage Disks from the Extra Storage mod on the To the Sky server because we feared that the increased capacity of the cells might be the root cause for the corruption of the storage files but since it happened again it seems like that was not the issue.

Also, here are some screenshots:

image Here you can see that the drives look empty but Jade displays the content in the top center, the disks are all still there

image When looking inside the drive, the disks are there, they still have their UUIDs but are otherwise completely unusable

image Here are the Refined Storage files in world/data/ post restart.

image These were the files before the server restart / from the backup. You can clearly see the size difference.

How can we reproduce this bug or crash?

Sadly, this error is not reliably reproducible. We restart the server every 6 hours and this is the first time it happened on the atm9sky server. As mentioned before, it also did happen on the regular atm9 server too, but also many weeks after the creation of the server.

What Minecraft version is this happening on?

Minecraft 1.20.1

What Forge version is this happening on?

47.2.20

What Refined Storage version is this happening on?

1.12.4

Relevant log output

[16Jul2024 18:00:27.330] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: Saving chunks for level 'ServerLevel[world]'/minecraft:overworld
[16Jul2024 18:00:28.171] [Server thread/ERROR] [com.refinedmods.refinedstorage.apiimpl.util.RSSavedData/]: Failed to rename refinedstorage_disks.dat.temp
[16Jul2024 18:00:29.146] [RCON Client /127.0.0.1 #18/ERROR] [com.refinedmods.refinedstorage.apiimpl.util.RSSavedData/]: Failed to rename refinedstorage_tracker.dat.temp
MojangPlsFix commented 1 month ago

The error could be related to File.moveTo(), called here. See Stackoverflow