search

refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
358 stars 177 forks source link

Failure Splitting Packets #3716

Open evhub opened 2 months ago

evhub commented 2 months ago

Describe the bug

I'm seeing a reappearance of #3466 even with the larger packet limit of 10. Would it be possible to increase the packet limit further?

How can we reproduce this bug or crash?

  1. Fill a storage system with items using a lot of data.
  2. Open a grid to view the items.
  3. Not all the items are visible.

What Minecraft version is this happening on?

Minecraft 1.20.1

What Forge version is this happening on?

47.3.0

What Refined Storage version is this happening on?

1.12.4

Relevant log output

[15:23:31] [Server thread/ERROR] [co.re.re.ne.PacketSplitter/]: Failure Splitting Packets on Channel "refinedstorage:main_channel". with class com.refinedmods.refinedstorage.network.grid.GridItemUpdateMessage.  Number of Packets sent 10, expected number of Packets 12, maximum number of packets for a message of this type 10
evhub commented 2 months ago

I'd also love a pointer to where in the code you set the packet limit so I can experiment with increasing it myself.

Darkere commented 2 months ago

https://github.com/refinedmods/refinedstorage/blob/83e4ba00e69c25409c29fbd41c1866e0ffa3097d/src/main/java/com/refinedmods/refinedstorage/network/NetworkHandler.java#L28