refinedmods / refinedstorage

An elegant solution to your hoarding problem.
https://refinedmods.com/refined-storage
MIT License
353 stars 175 forks source link

Kicked from server when opening my crafting grid - Payload may not be larger than 1048576 bytes #673

Closed ProsperCraft closed 6 years ago

ProsperCraft commented 7 years ago

Issue description:

I have a storage full of bees, and saplings from Forestry. Recently after adding more bees and saplings to it, I stated getting kicked when opening the crafting grid.

Steps to reproduce:

  1. breed lots of random bees, and trees
  2. insert them into the system
  3. keep adding until you can't open the system. ...

Does this issue occur on a server? yes

May be related to this- https://github.com/raoulvdberge/refinedstorage/issues/195

raoulvdberge commented 7 years ago

A temporary workaround would be to export all bees out with NBT compare off.

way2muchnoise commented 7 years ago

fragmented packets and stuff :'( Guess that'll be fun to code

raoulvdberge commented 7 years ago

We'll have to chain the grid update packet instead of sending it at once.

EvilNotion commented 7 years ago

raoulvdberge, would doing so reduce the amount of lag introduced to the system when you break power to your Controller and then reconnect? I have millions of items (lots in external Quantum Storage) and when I move my system or lose RF to it it tends to lag the server pretty badly.

way2muchnoise commented 7 years ago

No @EvilNotion that is related to #566

phit commented 7 years ago

I just ran into this myself in 1.10.. supposedly a player queued up a big crafting task.

fattness5 commented 7 years ago

This is happening to me in SkyFactory 3 whenever i look at my disk drives/controller.

raoulvdberge commented 7 years ago

@fattness5 Update HWYLA, this is another issue.

exetico commented 7 years ago

We see the same error here at Sky Factory 3 with Refined Storage 1.2.18: TranslatableComponent{key='disconnect.genericReason', args=[Internal Exception: java.lang.IllegalArgumentException: Payload may not be larger than 1048576 bytes], siblings=[], style=Style{... (Log file)

Triggered here by ordering a large amount of items and using Ctrl + Shift to force it to que it. We have multiple other autocrafting task running, but everytime we using the that feature, the server crashed.

We also see it after creating other smaller tasks, but that is not very often.

image

raoulvdberge commented 7 years ago

Why don't you update your SF3 instance before coming to the issue tracker? @exetico

exetico commented 7 years ago

@raoulvdberge - Oh, damn. I just forgot that my current setup didn't update the instance by itselves. Sorry for taking your time.

raoulvdberge commented 7 years ago

No problem, @exetico.

raoulvdberge commented 6 years ago

I can no longer reproduce this on 1.11+.

DBotThePony commented 6 years ago

plz grid

GianniKoch commented 3 years ago

I still have this issue till this day and idk what it is causing it. anyone that got wiser?

EDIT: I'm playing on ATM6, v1.5.7 I do store all mobdrops such as bows and stuff from skeletons n there, maybe I shouldn't?

smiba commented 3 years ago

Having this issue on ATM6 as well

"Payload may not be larger than 1048576 bytes" when opening the terminal. A lot of items such as armour are in our storage system, not sure if that matters?

@raoulvdberge or @way2muchnoise could you reopen this problem?

smiba commented 3 years ago

Never mind, this likely also belongs in #1790 -- Different location for this issue but in the end it comes down to the transport not supporting chunks / wanting to send it all at once

We did fix it by extracting all the tools and armour out of the system. There was a LOT in there. Because these don't stack (enchantments / varying levels of wear) they all show up as a separate item, likely making the item list massive.