Closed slsamg8327 closed 8 months ago
I managed to reproduce it with a minimal setup the whole system have a total of 20 different stacks of 1 item, both the importer and exporter have 9 filter set to items in the system exporter is set to random mode importer is set to whitelist in order to import only items that can be exported
I had to launch a calculation heavy stuff at the same time to slow down my CPU, but I think that having hundreds of item types make that unecessary I was unable to reproduce by remplacing the drawers by a chest
steps :
Mod | Version |
---|---|
Minecraft | 1.20.1 |
Fabric | 0.15.7* |
Fabric API | 0.92.0 |
Extended Drawers | 2.1.1 |
RS2 | 2.0.0-milestone.3.2 |
* different than op who had 0.15.6
``` ---- Minecraft Crash Report ---- // There are four lights! Time: 2024-02-20 11:09:23 Description: mouseClicked event handler java.util.ConcurrentModificationException at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) at java.base/java.util.HashMap$ValueIterator.next(HashMap.java:1625) at com.refinedmods.refinedstorage2.api.grid.view.GridViewImpl.sort(GridViewImpl.java:104) at com.refinedmods.refinedstorage2.api.grid.view.GridViewImpl.setFilterAndSort(GridViewImpl.java:76) at com.refinedmods.refinedstorage2.platform.common.grid.AbstractGridContainerMenu.onSearchTextChanged(AbstractGridContainerMenu.java:220) at com.refinedmods.refinedstorage2.platform.common.grid.AbstractGridContainerMenu.lambda$registerViewUpdatingListener$3(AbstractGridContainerMenu.java:213) at com.refinedmods.refinedstorage2.platform.common.grid.screen.GridSearchBoxWidget.lambda$new$1(GridSearchBoxWidget.java:36) at java.base/java.lang.Iterable.forEach(Iterable.java:75) at com.refinedmods.refinedstorage2.platform.common.grid.screen.GridSearchBoxWidget.lambda$new$2(GridSearchBoxWidget.java:36) at net.minecraft.class_342.method_1874(class_342.java:148) at net.minecraft.class_342.method_1852(class_342.java:104) at com.refinedmods.refinedstorage2.platform.common.support.widget.SearchFieldWidget.method_25402(SearchFieldWidget.java:35) at net.minecraft.class_4069.method_25402(class_4069.java:38) at net.minecraft.class_465.method_25402(class_465.java:290) at com.refinedmods.refinedstorage2.platform.common.support.AbstractBaseScreen.method_25402(AbstractBaseScreen.java:279) at com.refinedmods.refinedstorage2.platform.common.grid.screen.AbstractGridScreen.method_25402(AbstractGridScreen.java:475) at net.minecraft.class_312.method_1611(class_312.java:98) at net.minecraft.class_437.method_25412(class_437.java:409) at net.minecraft.class_312.method_1601(class_312.java:98) at net.minecraft.class_312.method_22686(class_312.java:169) at net.minecraft.class_1255.execute(class_1255.java:102) at net.minecraft.class_312.method_22684(class_312.java:169) at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) at org.lwjgl.system.JNI.invokeV(Native Method) at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403) at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:201) at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:212) at net.minecraft.class_1041.method_15998(class_1041.java:288) at net.minecraft.class_310.method_1523(class_310.java:1241) at net.minecraft.class_310.method_1514(class_310.java:802) at net.minecraft.client.main.Main.main(Main.java:250) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) A detailed walkthrough of the error, its code path and all known details is as follows: --------------------------------------------------------------------------------------- -- Head -- Thread: Render thread Stacktrace: at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1597) at java.base/java.util.HashMap$ValueIterator.next(HashMap.java:1625) at com.refinedmods.refinedstorage2.api.grid.view.GridViewImpl.sort(GridViewImpl.java:104) at com.refinedmods.refinedstorage2.api.grid.view.GridViewImpl.setFilterAndSort(GridViewImpl.java:76) at com.refinedmods.refinedstorage2.platform.common.grid.AbstractGridContainerMenu.onSearchTextChanged(AbstractGridContainerMenu.java:220) at com.refinedmods.refinedstorage2.platform.common.grid.AbstractGridContainerMenu.lambda$registerViewUpdatingListener$3(AbstractGridContainerMenu.java:213) at com.refinedmods.refinedstorage2.platform.common.grid.screen.GridSearchBoxWidget.lambda$new$1(GridSearchBoxWidget.java:36) at java.base/java.lang.Iterable.forEach(Iterable.java:75) at com.refinedmods.refinedstorage2.platform.common.grid.screen.GridSearchBoxWidget.lambda$new$2(GridSearchBoxWidget.java:36) at net.minecraft.class_342.method_1874(class_342.java:148) at net.minecraft.class_342.method_1852(class_342.java:104) at com.refinedmods.refinedstorage2.platform.common.support.widget.SearchFieldWidget.method_25402(SearchFieldWidget.java:35) at net.minecraft.class_4069.method_25402(class_4069.java:38) at net.minecraft.class_465.method_25402(class_465.java:290) at com.refinedmods.refinedstorage2.platform.common.support.AbstractBaseScreen.method_25402(AbstractBaseScreen.java:279) at com.refinedmods.refinedstorage2.platform.common.grid.screen.AbstractGridScreen.method_25402(AbstractGridScreen.java:475) at net.minecraft.class_312.method_1611(class_312.java:98) at net.minecraft.class_437.method_25412(class_437.java:409) at net.minecraft.class_312.method_1601(class_312.java:98) at net.minecraft.class_312.method_22686(class_312.java:169) at net.minecraft.class_1255.execute(class_1255.java:102) at net.minecraft.class_312.method_22684(class_312.java:169) at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) at org.lwjgl.system.JNI.invokeV(Native Method) at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403) at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:201) at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:212) -- Affected screen -- Details: Screen name: com.refinedmods.refinedstorage2.platform.common.grid.screen.GridScreen Stacktrace: at net.minecraft.class_437.method_25412(class_437.java:409) at net.minecraft.class_312.method_1601(class_312.java:98) at net.minecraft.class_312.method_22686(class_312.java:169) at net.minecraft.class_1255.execute(class_1255.java:102) at net.minecraft.class_312.method_22684(class_312.java:169) at org.lwjgl.glfw.GLFWMouseButtonCallbackI.callback(GLFWMouseButtonCallbackI.java:43) at org.lwjgl.system.JNI.invokeV(Native Method) at org.lwjgl.glfw.GLFW.glfwPollEvents(GLFW.java:3403) at com.mojang.blaze3d.systems.RenderSystem.pollEvents(RenderSystem.java:201) at com.mojang.blaze3d.systems.RenderSystem.flipFrame(RenderSystem.java:212) at net.minecraft.class_1041.method_15998(class_1041.java:288) at net.minecraft.class_310.method_1523(class_310.java:1241) at net.minecraft.class_310.method_1514(class_310.java:802) at net.minecraft.client.main.Main.main(Main.java:250) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) -- Affected level -- Details: All players: 1 total; [class_746['jonatjano'/167, l='ClientLevel', x=114.75, y=64.00, z=279.68]] Chunk stats: 961, 609 Level dimension: minecraft:overworld Level spawn location: World: (112,64,288), Section: (at 0,0,0 in 7,4,18; chunk contains blocks 112,-64,288 to 127,319,303), Region: (0,0; contains chunks 0,0 to 31,31, blocks 0,-64,0 to 511,319,511) Level time: 49781 game time, 6428 day time Server brand: fabric Server type: Integrated singleplayer server Stacktrace: at net.minecraft.class_638.method_8538(class_638.java:458) at net.minecraft.class_310.method_1587(class_310.java:2406) at net.minecraft.class_310.method_1514(class_310.java:821) at net.minecraft.client.main.Main.main(Main.java:250) at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:470) at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23) at org.prismlauncher.launcher.impl.StandardLauncher.launch(StandardLauncher.java:87) at org.prismlauncher.EntryPoint.listen(EntryPoint.java:130) at org.prismlauncher.EntryPoint.main(EntryPoint.java:70) -- Last reload -- Details: Reload number: 1 Reload reason: initial Finished: Yes Packs: vanilla, fabric -- System Details -- Details: Minecraft Version: 1.20.1 Minecraft Version ID: 1.20.1 Operating System: Linux (amd64) version 6.5.0-15-generic Java Version: 17.0.9, Private Build Java VM Version: OpenJDK 64-Bit Server VM (mixed mode, sharing), Private Build Memory: 1180573616 bytes (1125 MiB) / 3674210304 bytes (3504 MiB) up to 8589934592 bytes (8192 MiB) CPUs: 8 Processor Vendor: GenuineIntel Processor Name: Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz Identifier: Intel64 Family 6 Model 142 Stepping 12 Microarchitecture: Whiskey Lake Frequency (GHz): 1.80 Number of physical packages: 1 Number of physical CPUs: 4 Number of logical CPUs: 8 Graphics card #0 name: CometLake-U GT2 [UHD Graphics] Graphics card #0 vendor: Intel Corporation (0x8086) Graphics card #0 VRAM (MB): 256.00 Graphics card #0 deviceId: 0x9b41 Graphics card #0 versionInfo: unknown Virtual memory max (MB): 17362.27 Virtual memory used (MB): 19764.82 Swap memory total (MB): 9536.00 Swap memory used (MB): 5543.50 JVM Flags: 2 total; -Xms512m -Xmx8192m Fabric Mods: extended_drawers: Extended Drawers 2.1.1+mc.1.20.1 config_toolkit: ConfigToolkit 1.0.0 io_determann_shadow-api-17: shadow-api-17 0.1.1 net_fabricmc_javapoet: javapoet 0.1.0 graphlib: Graph Lib 1.4.0+1.20 kmodlib-overlay: KModLib Overlay 0.2.12+1.20 libnetworkstack: Lib Network Stack 0.10.0 yet_another_config_lib_v3: YetAnotherConfigLib 3.2.1+1.20 com_twelvemonkeys_common_common-image: common-image 3.10.0-SNAPSHOT com_twelvemonkeys_common_common-io: common-io 3.10.0-SNAPSHOT com_twelvemonkeys_common_common-lang: common-lang 3.10.0-SNAPSHOT com_twelvemonkeys_imageio_imageio-core: imageio-core 3.10.0-SNAPSHOT com_twelvemonkeys_imageio_imageio-metadata: imageio-metadata 3.10.0-SNAPSHOT com_twelvemonkeys_imageio_imageio-webp: imageio-webp 3.10.0-SNAPSHOT org_quiltmc_parsers_gson: gson 0.2.1 org_quiltmc_parsers_json: json 0.2.1 fabric-api: Fabric API 0.92.0+1.20.1 fabric-api-base: Fabric API Base 0.4.31+1802ada577 fabric-api-lookup-api-v1: Fabric API Lookup API (v1) 1.6.36+1802ada577 fabric-biome-api-v1: Fabric Biome API (v1) 13.0.13+1802ada577 fabric-block-api-v1: Fabric Block API (v1) 1.0.11+1802ada577 fabric-block-view-api-v2: Fabric BlockView API (v2) 1.0.1+1802ada577 fabric-blockrenderlayer-v1: Fabric BlockRenderLayer Registration (v1) 1.1.41+1802ada577 fabric-client-tags-api-v1: Fabric Client Tags 1.1.2+1802ada577 fabric-command-api-v1: Fabric Command API (v1) 1.2.34+f71b366f77 fabric-command-api-v2: Fabric Command API (v2) 2.2.13+1802ada577 fabric-commands-v0: Fabric Commands (v0) 0.2.51+df3654b377 fabric-containers-v0: Fabric Containers (v0) 0.1.64+df3654b377 fabric-content-registries-v0: Fabric Content Registries (v0) 4.0.11+1802ada577 fabric-convention-tags-v1: Fabric Convention Tags 1.5.5+1802ada577 fabric-crash-report-info-v1: Fabric Crash Report Info (v1) 0.2.19+1802ada577 fabric-data-attachment-api-v1: Fabric Data Attachment API (v1) 1.0.0+de0fd6d177 fabric-data-generation-api-v1: Fabric Data Generation API (v1) 12.3.4+1802ada577 fabric-dimensions-v1: Fabric Dimensions API (v1) 2.1.54+1802ada577 fabric-entity-events-v1: Fabric Entity Events (v1) 1.6.0+1c78457f77 fabric-events-interaction-v0: Fabric Events Interaction (v0) 0.6.2+1802ada577 fabric-events-lifecycle-v0: Fabric Events Lifecycle (v0) 0.2.63+df3654b377 fabric-game-rule-api-v1: Fabric Game Rule API (v1) 1.0.40+1802ada577 fabric-item-api-v1: Fabric Item API (v1) 2.1.28+1802ada577 fabric-item-group-api-v1: Fabric Item Group API (v1) 4.0.12+1802ada577 fabric-key-binding-api-v1: Fabric Key Binding API (v1) 1.0.37+1802ada577 fabric-keybindings-v0: Fabric Key Bindings (v0) 0.2.35+df3654b377 fabric-lifecycle-events-v1: Fabric Lifecycle Events (v1) 2.2.22+1802ada577 fabric-loot-api-v2: Fabric Loot API (v2) 1.2.1+1802ada577 fabric-loot-tables-v1: Fabric Loot Tables (v1) 1.1.45+9e7660c677 fabric-message-api-v1: Fabric Message API (v1) 5.1.9+1802ada577 fabric-mining-level-api-v1: Fabric Mining Level API (v1) 2.1.50+1802ada577 fabric-model-loading-api-v1: Fabric Model Loading API (v1) 1.0.3+1802ada577 fabric-models-v0: Fabric Models (v0) 0.4.2+9386d8a777 fabric-networking-api-v1: Fabric Networking API (v1) 1.3.11+1802ada577 fabric-networking-v0: Fabric Networking (v0) 0.3.51+df3654b377 fabric-object-builder-api-v1: Fabric Object Builder API (v1) 11.1.3+1802ada577 fabric-particles-v1: Fabric Particles (v1) 1.1.2+1802ada577 fabric-recipe-api-v1: Fabric Recipe API (v1) 1.0.21+1802ada577 fabric-registry-sync-v0: Fabric Registry Sync (v0) 2.3.3+1802ada577 fabric-renderer-api-v1: Fabric Renderer API (v1) 3.2.1+1802ada577 fabric-renderer-indigo: Fabric Renderer - Indigo 1.5.1+1802ada577 fabric-renderer-registries-v1: Fabric Renderer Registries (v1) 3.2.46+df3654b377 fabric-rendering-data-attachment-v1: Fabric Rendering Data Attachment (v1) 0.3.37+92a0d36777 fabric-rendering-fluids-v1: Fabric Rendering Fluids (v1) 3.0.28+1802ada577 fabric-rendering-v0: Fabric Rendering (v0) 1.1.49+df3654b377 fabric-rendering-v1: Fabric Rendering (v1) 3.0.8+1802ada577 fabric-resource-conditions-api-v1: Fabric Resource Conditions API (v1) 2.3.8+1802ada577 fabric-resource-loader-v0: Fabric Resource Loader (v0) 0.11.10+1802ada577 fabric-screen-api-v1: Fabric Screen API (v1) 2.0.8+1802ada577 fabric-screen-handler-api-v1: Fabric Screen Handler API (v1) 1.3.30+1802ada577 fabric-sound-api-v1: Fabric Sound API (v1) 1.0.13+1802ada577 fabric-transfer-api-v1: Fabric Transfer API (v1) 3.3.4+1802ada577 fabric-transitive-access-wideners-v1: Fabric Transitive Access Wideners (v1) 4.3.1+1802ada577 fabricloader: Fabric Loader 0.15.7 mixinextras: MixinExtras 0.3.5 java: OpenJDK 64-Bit Server VM 17 minecraft: Minecraft 1.20.1 refinedstorage2: Refined Storage 2 2.0.0-milestone.3.2 cloth-config: Cloth Config v10 10.0.96 cloth-basic-math: cloth-basic-math 0.6.1 com_refinedmods_refinedstorage2_refinedstorage2-query-parser_: refinedstorage2-query-parser 2.0.0-milestone.3.2 noindium: No Indium? 1.1.0+1.20 refinedstorage2-core-api: Refined Storage 2 Core API 2.0.0-milestone.3.2 refinedstorage2-grid-api: Refined Storage 2 Grid API 2.0.0-milestone.3.2 refinedstorage2-network: Refined Storage 2 Network 2.0.0-milestone.3.2 refinedstorage2-network-api: Refined Storage 2 Network API 2.0.0-milestone.3.2 refinedstorage2-resource-api: Refined Storage 2 Resource API 2.0.0-milestone.3.2 refinedstorage2-storage-api: Refined Storage 2 Storage API 2.0.0-milestone.3.2 team_reborn_energy: Energy 3.0.0 Launched Version: 1.20.1 Backend library: LWJGL version 3.3.1 SNAPSHOT Backend API: Mesa Intel(R) UHD Graphics (CML GT2) GL version 4.6 (Core Profile) Mesa 23.0.4-0ubuntu1~22.04.1, Intel Window size: 1920x1016 GL Caps: Using framebuffer using OpenGL 3.2 GL debug messages: Using VBOs: Yes Is Modded: Definitely; Client brand changed to 'fabric'; Server brand changed to 'fabric' Type: Integrated Server (map_client.txt) Graphics mode: fancy Resource Packs: fabric Current Language: en_us CPU: 8x Intel(R) Core(TM) i7-10610U CPU @ 1.80GHz Server Running: true Player Count: 1 / 8; [class_3222['jonatjano'/167, l='ServerLevel[New World]', x=114.75, y=64.00, z=279.68]] Data Packs: vanilla, fabric Enabled Feature Flags: minecraft:vanilla World Generation: Stable ```
Thank you all, this is great!
This should be fixed for upcoming release v2.0.0-milestone.3.4 for Minecraft 1.20.4.
I couldn't test myself so I'm not 100% sure, if the bug persists anyway please let us know.
Describe the bug
Environment: Fabric 1.20.1, RS2 Milestone 3.2, Extended Drawers 2.1.1
Entering a search query in the RS2 grid while a connected Extended Drawers setup (connected with an external storage interface + access point) that is constantly pulling and pushing single items into connected drawers (important that it's going from an empty to 1-64 stack state then back to 0 repeatedly) will cause the client to CTD or infrequently timeout from server.
How can we reproduce this bug or crash?
Setup simple RS2 system
Connect it to extended drawers using an external storage interface + access point
Continuously input and remove a single item from a connected drawer/ multiple drawers
Search for something inside the grid or generally interact with it
CTD / Server timeout (Netty)
https://github.com/refinedmods/refinedstorage2/assets/109295526/a89db670-4ca8-48a8-a61e-71c7be981ebc
What Minecraft version is this happening on?
Minecraft 1.20.1
What Forge or Fabric version is this happening on?
0.15.6 Fabric Loader, Fabric API 0.92.0
What Refined Storage version is this happening on?
Milestone 3.2
Relevant log output