Mccalluc/error page - Githubissues

refinery-platform / django_docker_engine

Django app that manages the creation of, and proxies requests to, Docker containers.

MIT License

6 stars 2 forks source link

Mccalluc/error page #75

Closed mccalluc closed 7 years ago

mccalluc commented 7 years ago

@scottx611x : Main idea is that static html can can be given until the docker container is up. Tests pass locally, but hit this on Travis:

File "/home/travis/build/refinery-platform/django_docker_engine/django_docker_engine/proxy.py", line 6, in <module>
    from django.views import View
ImportError: cannot import name View

Will try fiddling with my environment to see if I can reproduce.

--> It's a difference between python 1.7.1 and 1.10.6

Fixes #66

scottx611x commented 7 years ago

Also, after reviewing https://github.com/refinery-platform/refinery-platform/pull/2100, I think it would make sense to pass a template in here rather than a string, and have Django docker engine use a default template. Then we could pass things like the tool name that we're waiting for, among other things to the template context and render it.

mccalluc commented 7 years ago

Talked Scott out of the static variable: If we ever had different kinds, each with its own please-wait, they couldn't all use the same static class variable: Making a thow-away class inside the function is weird, but reflects what we actually want to happen.
Templates are a good idea but shouldn't block other work.