refinery-platform / heatmap-scatter-dash

Interactive visualizations for differential expression
MIT License
25 stars 1 forks source link

Mccalluc/better ids #199

Closed mccalluc closed 6 years ago

mccalluc commented 6 years ago

This provides more informative row labels in the heatmap. I have a few concerns:

I had begun it thinking it'd be an easy way to get a new version out, but there are enough changes here that I don't think that would be a good idea. I'll go back and make a trivial branch, and hopefully the travis rebuild will work.

mccalluc commented 6 years ago
mccalluc commented 6 years ago

@gmnelson / @scottx611x (and adding @jkmarx, new policy) If something is a slightly risky upgrade, how would you all feel about having 2 visualizations active in Refinery. It would also make it easier to compare performance one against the other.

(I still need to address the feedback from Geoff.)

gmnelson commented 6 years ago

@mccalluc If the 2 visualizations were named sufficiently different so that users were not confused as to which to use, I don't foresee this presenting an issue right now, given the limited usage. I can discuss this more, if needed, after the meeting tomorrow.

mccalluc commented 6 years ago

@jkmarx : Is this improved enough to merge? (Thanks for pushing back!)