search

refinery / refinerycms-authentication-devise

Devise based authentication extension for Refinery CMS
MIT License
17 stars 61 forks source link

Fix search #20

Closed stefanspicer closed 8 years ago

stefanspicer commented 8 years ago
bricesanchez commented 8 years ago

Do you have refinerycms-acts-as-indexed installed ?

Because it's already in this gem : https://github.com/refinery/refinerycms-acts-as-indexed/blob/master/app/decorators/models/refinery/user_decorator.rb

stefanspicer commented 8 years ago

I'm using https://github.com/rekotan/acts_as_indexed instead. I can't remember why off the top of my head, it was a long time ago. I guess I don't understand all the refinery specific things going into that https://github.com/refinery/refinerycms-acts-as-indexed/ repo. I thought acts-as-indexed was a more general search gem. I'll try to switch back to the refinery one.

bricesanchez commented 8 years ago

refinerycms-acts-as-indexed depends of acts_as_indexed: https://github.com/refinery/refinerycms-acts-as-indexed/blob/master/refinerycms-acts-as-indexed.gemspec#L17

In general, we don't want a dependency to acts_as_indexed for refinerycms-authentication-devise, like if i prefer to use another search engine.

stefanspicer commented 8 years ago

Wow, I'm obviously really confused. So I have an outdated version of refinerycms-acts-as-indexed (2.0.1). Pulling it directly from github fixes it. Is that expected? Just use the master branch?

bricesanchez commented 8 years ago

No problem, i will ping Philip to release a new version refinerycms-acts-as-indexed. Glad it fix your error.

You can use the master branch in waiting.