Supporting Rails 5

[sjoulbak]

Dear Refinery community 😄 ,

I've been busy with updating this gem, so the authentication will also work with Rails 5. This PR is currently using the feature/rails-5 branch for the dependencies refinerycms and refinerycms-i18n.

I've replaced except! with extract!, because except! will be deprecated in Rails 5.1. This function can be replaced with extract!, because we're only removing the :password and the password_confirmation in exclude_password_assignment_when_blank! from the user params.

The feature spec https://github.com/refinery/refinerycms-authentication-devise/blob/master/spec/features/refinery/authentication/devise/sessions_spec.rb#L119 will probably fail. This is caused by the new RefineryCMS UI, which is only less than half implemented. Maybe it's an idea that we'll remove this UI, because it's been 1,5 year and the UI isn't still fully implemented in Refinery? I'll create a special PR for this in the RefineryCMS gem, so you guys may make a call about it.

[bricesanchez]

Thanks for your contribution @sjoulbak!

I agree with you to revert new admin UI at this time in order to be able to easily ship a new version of Refinery and extensions with Rails 5 support.

After the Rails 5 support we could rework on the new admin UI.

Thoughts @parndt and @stefanspicer ?

[parndt]

I've merged your other PR for the UI 😄

[sjoulbak]

Thank you Philip for approving the PR 😄

I think that we should wait merging this PR, because we're still using the feature/rails-5 branch here in the Gemfile. I'll update the Gemfile when that PR is merged.

[parndt]

👍 thanks for that @sjoulbak

[sjoulbak]

@parndt Do you agree with: https://github.com/sjoulbak/refinerycms-authentication-devise/pull/1 ?

[parndt]

@sjoulbak sure, but you'll need to open the PR on this repo for me to merge it 😄

[sjoulbak]

Haha I only wanted your approvement 😉 It's merged into this branch

[bricesanchez]

Closed in favor of #34