Hides failure message on password recovery

[bricesanchez]

• Mitigate brute force attacks by giving no clue on existing accounts
• Refactor Refinery::Authentication::Devise::PasswordsController
• Fix offences with Rubocop

[bricesanchez]

@parndt i don't see codeclimate on this repo? Could you check why it's not activated on all the organization?

[parndt]

It's definitely configured for this repo

[bricesanchez]

It's definitely configured for this repo

It's weird, i don't see it in the timeline actions with Travis CI.

[parndt]

It is weird, indeed.

[bricesanchez]

@parndt Could you review this PR please?

[parndt]

@bricesanchez yeah, can you please add screenshots showing how you expect this to function now?

[bricesanchez]

Yes.

Before it could helps a hacker to find which account is used as refinery Admin

Now it give no clue, it always returns that an email has been send even if it does not send an email if the account does not exist

It mitigate brute force attacks.

[parndt]

Thanks for doing it @bricesanchez :+1: