search

refinery / refinerycms-authentication-devise

Devise based authentication extension for Refinery CMS
MIT License
17 stars 61 forks source link

Add support for Rails 6. #45

Closed joebutler2 closed 4 years ago

joebutler2 commented 4 years ago

I'm sorry, there is a lot of churn on this PR at the moment. It looks like we need dist: trusty, and your suggestion for removing the patch versions worked!

Yes, you are correct, this does not run against Rails 6 in CI. Though this update will enable us to use it in a Rails 6 app. I already have it working on my current project!

bricesanchez commented 4 years ago

@parndt i can't merged this PR because it looks like it need signed commits. What should we do?

parndt commented 4 years ago

Well that's weird, not sure why that was required. Fixed!

ttmthanh commented 4 years ago

@parndt Sorry sir, when I upgrade refinery-authentication to refinery-authentication-devise. I have old data, please tell me "What to do with the database" :(

parndt commented 4 years ago

https://github.com/refinery/refinerycms-authentication-devise#installation

ttmthanh commented 4 years ago

@parndt Why url changes when we upgrade. /refinery/login --> /refinery/users/login when login false

parndt commented 4 years ago

Here's the routes file: https://github.com/refinery/refinerycms-authentication-devise/blob/master/config/routes.rb

It's probably Devise doing that.

ttmthanh commented 4 years ago

Can I change the routes as it was originally?

ttmthanh commented 4 years ago

Please help me change :'(

parndt commented 4 years ago

We haven't changed the routes file in over 4 years. If behaviour has changed, it'll be something to do with Devise. I'd suggest reading through those docs 😄 good luck! I can't be any further help on this.