search

refinery / refinerycms-calendar

Refinery CMS Events Engine
http://refinerycms.com
69 stars 73 forks source link

I18n support #27

Open luis-mendo opened 12 years ago

luis-mendo commented 12 years ago

Adding I18n support.

jurriaan commented 11 years ago

@parndt Do you have an idea when i18n support will be added?

brenes commented 11 years ago

@jurriaan if you are interested we have a fork of this gem with i18n included: https://github.com/simplelogica/refinerycms-calendar

The gem is refinerycms-sl-calendar :)

simi commented 11 years ago

@brenes is it backward compatible?

parndt commented 11 years ago

I don't know whether to merge this or #28 can you all help me out here please?

jurriaan commented 11 years ago

This one deals with translation of the event data (title/description etc). I think #28 doesn't

parndt commented 11 years ago

@joemsak any chance that you can you help out here please?

simi commented 11 years ago

@parndt be careful for backward compatibility.

joemsak commented 11 years ago

This PR seems much more concentrated to one task..

joemsak commented 11 years ago

Although the other one renames the columns "from" and "to" to start/end_at which is smart too

brenes commented 11 years ago

@simi it should be backwards compatible as we have not modified any test (we only added tests) and in the migration we use the migrate data: true when creating the translation table. When we implemented it we migrate from this gem to this version with no reported problem

brenes commented 11 years ago

@parndt, @joemsak as @jurriaan states the other PR is not about the model translation but texts translation

brenes commented 11 years ago

@joemsak from and to was renamed in PR #38 that has been already merged :)

parndt commented 11 years ago

I think there is some confusion. The PR I merged had starts_at and ends_at. I don't like the pluralisation but that's what we have.