search

refinery / refinerycms-calendar

Refinery CMS Events Engine
http://refinerycms.com
69 stars 73 forks source link

I18n for the _event partial && updated English and Dutch locales #6

Closed suweller closed 12 years ago

suweller commented 13 years ago

move all translations from _event partial to locale file and update en: && nl:

suweller commented 13 years ago

I'm going to go through all the views to make sure there is no plain text in it. Since I only speak Dutch and English, I can not update the other locales.

joemsak commented 13 years ago

I don't understand the use of Event.human_attribute_name and its difference from using t('.something')... can you elaborate? Thanks!

suweller commented 13 years ago

Event.human_attribute_name is just a shorthand to get to activerecord.attributes.model_name.attribute

The main difference would be that it does not expand to the view file it is called from but to the model

suweller commented 13 years ago

I'll branch my fork. Other commits will no longer be made in master in order not too place too many of them in a pull request.

Also, if you are not interested in my changes I will close the pull request

joemsak commented 13 years ago

I am, it just wouldn't merge automatically anymore and I've been busy, sorry

On Tue, Sep 20, 2011 at 1:42 PM, suweller < reply@reply.github.com>wrote:

I'll branch my fork. Other commits will no longer be made in master in order not too place too many of them in a pull request.

Also, if you are not interested in my changes I will close the pull request

Reply to this email directly or view it on GitHub: https://github.com/resolve/refinerycms-calendar/pull/6#issuecomment-2148341

parndt commented 12 years ago

Any chance this can be made mergeable?

suweller commented 12 years ago

I'll try to merge it this Saturday.

Will one of you guys be on irc#refinerycms or skype just in case I get nasty merge-conflicts?

suweller commented 12 years ago

I've rebased but there is no way I can run the specs of this repo without spec/spec_helper, so I can't give any guarantees. If someone could fix that, I'd be happy to make my repo changes pass the specs

parndt commented 12 years ago

cc @joemsak

joemsak commented 12 years ago

Tried adding refinerycms-testing according to the guide in this branch...

https://github.com/resolve/refinerycms-calendar/tree/suweller-master

But maybe the guide is only for 2.0 extensions?

I got this error after updating the Rakefile

$ bundle exec rake refinery:testing:dummy_app
rake aborted!
uninitialized constant ActionController

(See full trace by running task with --trace)
parndt commented 12 years ago

Yeah the guide is only for 2.0 extensions unfortunately..