search

refinery / refinerycms-news

News Plugin for Refinery CMS
http://www.refinerycms.com
MIT License
121 stars 120 forks source link

Fix for archive bug #97

Closed julesce closed 12 years ago

julesce commented 12 years ago

Hi guys,

Here is my fix for the archive bug mentioned in #96.

Not sure how the original method worked, so I've just rewritten it accordingly. It will simply list the months in which there were posts, along with a post count in brackets.

Use it - don't use it - just thought I'd share it :-)

twinge commented 12 years ago

any chance you can merge this fix into 2.0-stable?

byropig commented 12 years ago

when will this be merged into the latest gem??

ugisozols commented 12 years ago

This is kind of breaking backwards compatibility... @parndt can we put this in point release?

parndt commented 12 years ago

Yes; thoroughly documented with a deprecation warning

ugisozols commented 12 years ago

Alright, I'll do it asap.

ugisozols commented 12 years ago

The fix is in 2-0-stable now along with deprecation warning.

creativereason commented 12 years ago

I'm still seeing this bug in my refinery site after updating to the 2.0.1 gem (locally, haven't pushed to heroku yet). Still shows the same month 5 times (there are five posts). I've run a bundle update, any ideas or suggestions?

ugisozols commented 12 years ago

New version hasn't been released yet so to get this fix now you can point refinerycms-news gem to this repo and use 2-0-stable branch:

# in Gemfile
gem "refinerycms-news", :git => "git://github.com/refinery/refinerycms-news.git", :branch => "2-0-stable"

Remember to rebundle.

creativereason commented 12 years ago

Sorry for commenting on two issues. I'll do that. Thanks for the quick reply.

creativereason commented 12 years ago

So updating to this version breaks my layout of the news page for some reason (looks like there are additional css classes in that section). Is there a way to overwrite the view for the archives?

creativereason commented 12 years ago

Ignore my comment, I'm working around via css, but it looks like the old version had a section id of body_content_right and the new archive section has an id of side_body. Should I submit a pull to fix that one part?

ugisozols commented 12 years ago

We changed from body_content_right to side_body in Refinery itself so side_body is correct. Maybe 65e2ac91b3074fd5707f78e1eca0a623eec3167f shouldn't be in 2-0-stable but I hope you can upgrade without much of hassle.