search

refinery / refinerycms-page-images

Adds an images tab to your pages so you can format a group of images really nicely on the frontend
105 stars 120 forks source link

Add support for Refinery 4.0 #148

Closed bricesanchez closed 6 years ago

bricesanchez commented 7 years ago

@parndt i think test are failing because belongs_to associations has required: true since Rails 5.0 and i'm ok with that on this model: https://github.com/refinery/refinerycms/blob/master/pages/app/models/refinery/page_part.rb#L4

But how could we fix the factories?

bricesanchez commented 6 years ago

@parndt šŸ†™ šŸ™ƒ

bricesanchez commented 6 years ago

Sorry iā€™m not sure to understand what i need to change

parndt commented 6 years ago

If the belongs to is required then to fix the factories we would need to ensure the relationship gets created? Am I missing something?

bricesanchez commented 6 years ago

How could I ensure the relationship is created?

bricesanchez commented 6 years ago

This PR https://github.com/refinery/refinerycms/pull/3338 will fix the specs of this extension.

bricesanchez commented 6 years ago

Could you review it @parndt ?