refinery / refinerycms

An extendable Ruby on Rails CMS that supports Rails 6.0+
https://www.refinerycms.com/
MIT License
3.9k stars 1.26k forks source link

No support for Rails 5.2? #3450

Open JRice opened 4 years ago

JRice commented 4 years ago

I cannot find a version of https://github.com/refinery/refinerycms/blob/4.0.0/core/refinerycms-core.gemspec that allows Rails 5.2.

...Is this intentional? Is there no support for Rails 5.2 in Refinery CMS?

simi commented 4 years ago

AFAIK there's no release for Rails 5.2 support. Rails 6 support is on the way (in master already), Rails 5.2 was added to master, but not released yet -> https://github.com/refinery/refinerycms/commit/e49a6bebefe34bedcca932887f1446f084a23c33#diff-e61c4dff501e6ff3682da137f9b5761d.

bricesanchez commented 4 years ago

Hi @JRice,

It was not intentional. Sorry!

Master branch was compatible with Rails 5.2 until this commit 81ed9917c0ed528bdcb0d91bbecf408d3c89706a

We could probably release a new version of Refinery for this Rails version.

What do you think @parndt ?

parndt commented 4 years ago

Yes, it is probably about time!

anitagraham commented 4 years ago

I am in this predicament too. The subtitle for the repository says "...supporting Rails 5.2+" so I think not having a 5.2 compatible release is an oversight.

I'd be happy to move on with Rails 6, but I'm not certain how many refinery extensions will need updating.

bricesanchez commented 4 years ago

@parndt Could you release a version for rails 5.2 with this commit 81ed991 ?

theRealNG commented 4 years ago

Waiting for rails 5.2 support atleast

parndt commented 4 years ago
gem "refinerycms", git: "https://github.com/refinery/refinerycms", ref: "81ed991"
hdmr14 commented 4 years ago

Will 81ed991 released as 4.1.0 or something else? update directly via github can't manage with versioning causes next update eventually difficult.