search

reflection / designmodo-flatuipro-rails

Designmodo's Flat UI Pro Design for Twitter Bootstrap integration into the Rails 3 and 4 Asset Pipeline
BSD 2-Clause "Simplified" License
66 stars 20 forks source link

Sprockets::CircularDependencyError at / app/assets/stylesheets/application.css has already been required #14

Open akshatpradhan opened 11 years ago

akshatpradhan commented 11 years ago

I'm using the twitter-bootstrap-rails gem that uses less and application.css.less is already defined. Perhaps it might be good to not include application.css when using that gem?

I'm not entirely sure, but I thought I would bring it to your attention.

screen shot 2013-08-12 at 10 10 42 am

akshatpradhan commented 10 years ago

@adamico saw this issue as well and manually had to remove application.css. I'm not sure if this affects other people too, but I think its safe to assume application.css is included by default in a rails app, and thus this gem doesn't need to add it.

reflection commented 10 years ago

The install generator is modeled after the generator in the twitter-bootstrap-rails gem. Like the other gem, the generator only copies over a template version of application.css if it can't find the file; otherwise it just ensures that either 'require tree' is in the file, else 'require flatuipro'

Out of curiosity, if you just installed the twitter-bootstrap-rails gem in your application and CI'd it I wonder if you would receive the same error? Unfortunately we don't use Travis so I haven't experienced any CI problems firsthand, but perhaps later when I have some time I'll see if I can replicate your issues.