search

reflectivity / orsopy

http://www.reflectometry.org/orsopy/
MIT License
0 stars 8 forks source link

MAINT: make default polarization - unpolarized #117

Closed andyfaff closed 12 months ago

andyfaff commented 12 months ago

Would close #110 - if we decided it needed "fixing".

@jfkcooper @jochenstahn @aglavic @bmaranville

bmaranville commented 12 months ago

Yes, we should definitely change this default to unpolarized... undefined makes no sense at all. If you don't know the polarization state of your beam it's like not knowing your wavelength - you can't interpret the data.

aglavic commented 12 months ago

@andyfaff I agree with the change of the default value.

However, I think this has a formal bug that needs fixing.

default="unpolarized", will probably pass the test, but I think it should be default=Polarization.unpolarized

Otherwise the value upon creation of the class will be the actual string, not the Enum, I think.