search

reflex-dev / reflex

🕸️ Web apps in pure Python 🐍
https://reflex.dev
Apache License 2.0
20.42k stars 1.18k forks source link

[ENG-4080]Downgrade syntax highlighter to fix `wrapLongLines` issue #4368

Closed ElijahAhianyo closed 3 days ago

ElijahAhianyo commented 1 week ago

ReactSyntaxHighligter v15.16.1 breaks the functionality of the wrap_long_line prop. Downgrading to 15.16.0 works.

Related upstream PR: https://github.com/react-syntax-highlighter/react-syntax-highlighter/pull/487

linear[bot] commented 1 week ago

ENG-4080 Code_block "wrap_long_lines" not working anymore

adhami3310 commented 1 week ago

How does ReactSyntaxHighligter v15.16.1 break it? i looked at the PR and it doesn't seem doing anything bad?

ElijahAhianyo commented 1 week ago

How does ReactSyntaxHighligter v15.16.1 break it? i looked at the PR and it doesn't seem doing anything bad?

That's what's not obvious to me. We don't, by default, set any css props, which should work the way it is. The referenced PR only swaps the order of args, so maybe a chain of reaction somewhere? I haven't dug into the reactsyntaxhighlighter codebase to to see what other parts may have been affected. Either way, Im not sure if this will require a fix from us than them.