ryantrinkle
commented
6 years ago DeriveAnyClass just makes an empty instance, iirc. Why not just do that directly?
On Wed, Nov 7, 2018, 05:27 Divam <notifications@github.com wrote:
@dfordivam commented on this pull request.
In common/src/Common/Route.hs https://github.com/reflex-frp/reflex-frp.org/pull/35#discussion_r231452015 :
@@ -12,10 +12,9 @@ {-# LANGUAGE ScopedTypeVariables #-} {-# LANGUAGE StandaloneDeriving #-} {-# LANGUAGE TemplateHaskell #-} +{-# LANGUAGE DeriveAnyClass #-}
Required for deriving Universe, not sure if enabling this can mess with something else..
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/reflex-frp/reflex-frp.org/pull/35#pullrequestreview-172423969, or mute the thread https://github.com/notifications/unsubscribe-auth/ABGlYBcTqa-Gw9EjhwE53lHzd8o-4hHNks5usrWagaJpZM4YSKGV .
ali-abrar
This time I used the simpler approach of Either, and specified the optional ordering using a user specified list.
And the link to GitHub is shown both on full size and mobile screen. I have increased the size to 750px as the 600px cuts the existing nav bar. If we want to keep it to 600px, we might have to reduce the size of nav, or show sub menus.
Fixes #31, Fixes #32