reflow-project / weloop

WeLoop is a React/TypeScript client for ZenPub and a key component of ReflowOS
https://weloop.reflowproject.eu
GNU Affero General Public License v3.0
5 stars 5 forks source link

Fix issues on economic resources flows #138

Closed pral2a closed 3 years ago

pral2a commented 3 years ago
  1. Currently when we create an economic event on top of an existing economic resource (see Perform an event button) we are creating a new economic resource every time. That shouldn't be the default case. An economic event could be applied on top an economic resource without creating a new one. That means we need to replace createEconomicEventAndNewResource for createEconomicEvent. https://github.com/reflow-project/weloop/blob/be1afe00867b2af4d1f3f577621423a09260d9bd/src/fe/resource/create/useCreateResource.graphql#L1 _See Reflow OS (ZenPub / Bonfire) documentation Conduct an economic event on an existing resource_

  2. After (1) we should allow users to select if the economic event will create a new economic resource. In this case, an only optionally, the user can create a new economic resource that will result as part of the event. For it we should provide a view to input the same fields available on the "Create a new Resource" pop-up. We could maybe have a toggle option inside the economic event that includes the "Create a new Resource" information and can be only selected optionally. In this case we will use the original createEconomicEventAndNewResource https://github.com/reflow-project/weloop/blob/be1afe00867b2af4d1f3f577621423a09260d9bd/src/fe/resource/create/useCreateResource.graphql#L1 _See Reflow OS (ZenPub / Bonfire) documentation in Conduct an economic event that results in a completely new resource._

Explanatory chart:

weloop-resource-event-flow