search

reflux / refluxjs

A simple library for uni-directional dataflow application architecture with React extensions inspired by Flux
BSD 3-Clause "New" or "Revised" License
5.36k stars 330 forks source link

Please add "dist" folder to npm package. #441

Closed mykhailo-ivankiv closed 8 years ago

devinivy commented 8 years ago

Hi @neformal13– this seems to be a dupe of an old issue. More info at https://github.com/reflux/refluxjs/issues/397. If #448 is reconsidered, I'll try to update you here.

jeffrifwald commented 8 years ago

@neformal13 in the meantime, I created a package called reflux-dist in npm that is just a mirror of this package without the issue.

devinivy commented 8 years ago

Good to know for others who run into this issue– thanks @jmcriffey.

@jmcriffey and @neformal13 can you explain your workflow and why it doesn't use a webpack/browserify to bundle the commonjs modules you use? Could you point to other libraries that ship a dist on npm?

jeffrifwald commented 8 years ago

Basically none of the other modules I can think of need to go through my build; they all include a dist in an npm repo. Having to build this package is disruptive to a workflow that seems pretty common. By not distributing a build, you are also expecting me to compile the same way as this package. Imagine my build process used a very small subset of ES2015 or only targeted JSX, then I'd be in trouble trying to compile reflux-core.

To name a few libraries that include a dist in the npm repo: React, Lodash, D3, Babel's Polyfill, Moment, Redux.

devinivy commented 8 years ago

You make a good case! I leave this up to @spoike to make the final call.

devinivy commented 8 years ago

Closed by #448. Thanks to both of you for bearing with us.

jeffrifwald commented 8 years ago

Thanks @devinivy, I appreciate it!

devinivy commented 8 years ago

v0.3.1 is identical to v0.3.0, but includes the dist folder on npm.