refnx / refnx-binder

Interesting notebooks for viewing on Binder
0 stars 1 forks source link

Motofit app doesn't run on Binder #1

Open linupi opened 1 year ago

linupi commented 1 year ago

I just tried t launch this repo on Binder and got the following error

---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
/tmp/ipykernel_87/2377668251.py in <module>
----> 1 app = Motofit()

/srv/conda/envs/notebook/lib/python3.7/site-packages/refnx/reflect/_interactive_modeller.py in __init__(self)
    849 
    850         self.tab = widgets.Tab()
--> 851         self.tab.set_title(0, "Model")
    852         self.tab.set_title(1, "Limits")
    853         self.tab.set_title(2, "Options")

/srv/conda/envs/notebook/lib/python3.7/site-packages/ipywidgets/widgets/widget_selectioncontainer.py in set_title(self, index, title)
     67         if title is None:
     68             title = ''
---> 69         titles[index]=title
     70         self.titles = tuple(titles)
     71 

IndexError: list assignment index out of range

Binder output: reflection_analysis.pdf

andyfaff commented 1 year ago

I'll have a look tomorrow.

andyfaff commented 1 year ago

I have just removed a pin on the refnx version to a more recent version that doesn't have the issue you reported. I can run the notebook at home, so it should be runnable in binder.

andyfaff commented 1 year ago

It turns out that that statement isn't correct. The issue will be fixed in refnx 0.1.31, but I haven't yet released that.