refracta / dcss-server

Containerized DCSS Server
https://crawl.nemelex.cards
GNU General Public License v3.0
6 stars 0 forks source link

New target features & configurations #95

Open refracta opened 5 months ago

refracta commented 5 months ago
Rytisgit commented 5 months ago
refracta commented 5 months ago

The checkboxes look much cleaner, thank you.

That option is a bit different from the WebTerm I want. The official NetHack server, NAO server, has a feature that allows playing dgamelaunch sessions on the web using WebSocket (maybe). I would like to support this if possible (although it's a very low-priority issue).

refracta commented 5 months ago

By the way, there is an issue where the trunk update via cron does not occur automatically. This could be due to the modifications I have made so far, but I would like to know if the cron was working well (tested) in your original project from which I forked.

If the cron was working well in your original project, it is likely that the issue is not with the cron itself, but rather with the DGL script.

Rytisgit commented 5 months ago

Yes, the cron was not working well to update the trunk for me either, this is why I mentioned that it is unreliable in the issues of my project, Perhaps it's not cron itself but the way it's running the update commands. But it seems that it has carried over to your project as well.

I do know about the webterm you are speaking about, I just mentioned the options in rc, in case you thought it was terminal-like enough.

refracta commented 5 months ago

Thank you for letting me know. Since recognizing the issue two days ago, I have set up a manual process to update every 15 minutes, but this is just a temporary solution. This problem is probably the most urgent one to resolve.

I have experienced issues where certain environment variables were not correctly applied in the cron environment within a container. Therefore, I had to hardcode paths to make it work. This might be a similar problem. https://gist.github.com/refracta/559e91a9d4686624556a6733c2191cdf (node not work, /usr/local/bin/node work properly)

refracta commented 5 months ago

I confirmed that the cron process functions properly when started manually from within the container shell. Therefore, I added the cron command to the startup script. I need to resolve some build issues currently encountered to proceed with production test, but I believe this problem likely has been fixed. https://github.com/refracta/dcss-server/commit/eb6ca1272b139e15d8e59551472bd0ff61afa8fe