search

reframe-hpc / reframe

A powerful Python framework for writing and running portable regression tests and benchmarks for HPC systems.
https://reframe-hpc.readthedocs.org
BSD 3-Clause "New" or "Revised" License
214 stars 102 forks source link

hpctestlib/microbenchmarks/gpu/memory_bandwidth should pick up gpu_build the same way gpu_burn does #2756

Open akesandgren opened 1 year ago

akesandgren commented 1 year ago

gpu_burn does:

        if self.gpu_build is None:
            # Try to set the build type from the partition features
            if 'cuda' in curr_env.features:
                self.gpu_build = 'cuda'
            elif 'hip' in curr_env.features:
                self.gpu_build = 'hip'

I think memory_bandwidth should do the same.

akesandgren commented 1 year ago

It should probably also use

    valid_systems = ['+gpu']
    valid_prog_environs = ['+cuda', '+hip']

like gpu_burn does to simplify usage.

vkarak commented 1 year ago

I think that this test should be modernised and rewritten, because it follows pre-testlib practices. The two tests have been developed independently.