search

reframe-hpc / reframe

A powerful Python framework for writing and running portable regression tests and benchmarks for HPC systems.
https://reframe-hpc.readthedocs.org
BSD 3-Clause "New" or "Revised" License
214 stars 101 forks source link

[bugfix] Do not ignore the `use_login_shell` configuration option when generation the auto-detection script #3094

Closed ekouts closed 7 months ago

ekouts commented 7 months ago

This is useful for the firecrest scheduler, but probably also for other schedulers.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (62ee308) 86.63% compared to head (3a30e58) 86.63%.

Files Patch % Lines
reframe/frontend/autodetect.py 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3094 +/- ## ========================================== - Coverage 86.63% 86.63% -0.01% ========================================== Files 61 61 Lines 12041 12042 +1 ========================================== Hits 10432 10432 - Misses 1609 1610 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vkarak commented 7 months ago

Could we add a unit test for this?