search

reframe-hpc / reframe

A powerful Python framework for writing and running portable regression tests and benchmarks for HPC systems.
https://reframe-hpc.readthedocs.org
BSD 3-Clause "New" or "Revised" License
214 stars 101 forks source link

[bugfix] Detect missing `curl` in `bootstrap.sh` #3096

Closed tmjbios closed 7 months ago

tmjbios commented 7 months ago

Curl is not a default package on most Linux distributions, and is not listed as a requirement for reFrame.

When curl is missing, bootstrap.sh will blow right past the curl failure and continue to attempt to execute commands.

Add a check for curl, and print a meaningful message + exit if it is not found.

jenkins-cscs commented 7 months ago

Can I test this patch?

tmjbios commented 7 months ago

Yes.

To test locally, I used a default Ubuntu 22.04 server, cloned the repo and ran bootstrap, installed curl, the re-ran bootstrap.

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e118231) 86.63% compared to head (4cf84a6) 86.63%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3096 +/- ## ======================================= Coverage 86.63% 86.63% ======================================= Files 61 61 Lines 12041 12041 ======================================= Hits 10432 10432 Misses 1609 1609 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vkarak commented 7 months ago

@tmjbios Thanks for the fix. I updated your PR to be against master as it's a bug fix and we could release it in the next patch release.