Closed tmjbios closed 7 months ago
Can I test this patch?
Yes.
To test locally, I used a default Ubuntu 22.04 server, cloned the repo and ran bootstrap, installed curl, the re-ran bootstrap.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e118231
) 86.63% compared to head (4cf84a6
) 86.63%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tmjbios Thanks for the fix. I updated your PR to be against master as it's a bug fix and we could release it in the next patch release.
Curl is not a default package on most Linux distributions, and is not listed as a requirement for reFrame.
When curl is missing, bootstrap.sh will blow right past the curl failure and continue to attempt to execute commands.
Add a check for curl, and print a meaningful message + exit if it is not found.