search

reframe-hpc / reframe

A powerful Python framework for writing and running portable regression tests and benchmarks for HPC systems.
https://reframe-hpc.readthedocs.org
BSD 3-Clause "New" or "Revised" License
214 stars 101 forks source link

[bugfix] Better version check for Slurm in the `srun` backend #3109

Closed vkarak closed 6 months ago

vkarak commented 7 months ago

This covers also the cases when Slurm is installed through apt, where it's name is slurm-wlm.

pep8speaks commented 7 months ago

Hello @vkarak, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-02-08 22:50:17 UTC
codecov[bot] commented 7 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e7fcd19) 86.63% compared to head (165481d) 86.63%.

Files Patch % Lines
reframe/core/launchers/mpi.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #3109 +/- ## ======================================= Coverage 86.63% 86.63% ======================================= Files 61 61 Lines 12042 12042 ======================================= Hits 10432 10432 Misses 1610 1610 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.