search

reframe-hpc / reframe

A powerful Python framework for writing and running portable regression tests and benchmarks for HPC systems.
https://reframe-hpc.readthedocs.org
BSD 3-Clause "New" or "Revised" License
213 stars 100 forks source link

[doc] Update `Job.nodelist` description #3155

Closed jack-morrison closed 3 months ago

jack-morrison commented 3 months ago

Fixes #3143.

@vkarak I'm not seeing the recent PBS change you mentioned on #3143 - do you mind pointing me to it? Am I correct in assuming that Slurm is no longer the only backend where this attribute is reliably set?

jenkins-cscs commented 3 months ago

Can I test this patch?

vkarak commented 3 months ago

ok to test

vkarak commented 3 months ago

@vkarak I'm not seeing the recent PBS change you mentioned on #3143 - do you mind pointing me to it? Am I correct in assuming that Slurm is no longer the only backend where this attribute is reliably set?

The docs are from version 3.2 (see 0f1c2a98960c6e3ba8d48e4f00ad358ccb204f07), but the support for the nodelist in PBS came in 3.3 (see 330c7b4b2616d04e6787d868cdf10de677fde983). The full list of the backends that support it is: local, pbs, slurm, squeue, ssh, torque.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.65%. Comparing base (60b2152) to head (bd4dd0e). Report is 5 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3155 +/- ## ======================================== Coverage 86.65% 86.65% ======================================== Files 61 61 Lines 12117 12117 ======================================== Hits 10500 10500 Misses 1617 1617 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.