search

reframe-hpc / reframe

A powerful Python framework for writing and running portable regression tests and benchmarks for HPC systems.
https://reframe-hpc.readthedocs.org
BSD 3-Clause "New" or "Revised" License
213 stars 100 forks source link

[bugfix] Treat OR Slurm constraints in flexible node allocation #3158

Closed vkarak closed 3 months ago

vkarak commented 3 months ago

This PR fixes also the way sched_access constraints are combined with those specified in the CLI or in the job.options by parenthesizing appropriately. It also updates the docs.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.66%. Comparing base (7272c08) to head (2d1eca4). Report is 1 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #3158 +/- ## =========================================== + Coverage 86.65% 86.66% +0.01% =========================================== Files 61 61 Lines 12121 12134 +13 =========================================== + Hits 10503 10516 +13 Misses 1618 1618 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vkarak commented 3 months ago

I would still need to add a unit test to check the behaviour with an invalid expression.

pep8speaks commented 3 months ago

Hello @vkarak, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2024-04-15 16:55:58 UTC