search

refresh-bio / KMC

Fast and frugal disk based k-mer counter
256 stars 73 forks source link

fix release name; merge more fixes? #100

Closed notestaff closed 5 years ago

notestaff commented 6 years ago

@marekkokot sorry, I suggested the wrong name for the release tag. per https://www.python.org/dev/peps/pep-0440/ it should be 3.1.1rc1 . it's a release candidate for the (future) version 3.1.1, not the current 3.1.0; and version names in conda cannot have dashes.

also, maybe merge fixes #97 and #98 if these are ok? thanks!

marekkokot commented 6 years ago

Its done. I started to think about this aspect after I created this release and I was intended to check it. Now I don't need to, so thanks :).

notestaff commented 6 years ago

@marekkokot https://www.python.org/dev/peps/pep-0440/ says it should be 3.1.1rc1 not 3.1.1rc.1 . sorry for nitpicking, but these are requirements of conda/bioconda .

marekkokot commented 6 years ago

No problem, is that OK now?

marekkokot commented 5 years ago

I assume it was OK, and I am closing this issue. If something is wrong just reopen it and supply some more info.